Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: backport to handle commit messages safely #3247

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

Yaminyam
Copy link
Member

@Yaminyam Yaminyam commented Dec 13, 2024

This pull request includes a small but important change to the .github/workflows/backport.yml file. The change involves setting an environment variable for the commit message to simplify and clean up the script.

  • Added COMMIT_MESSAGE environment variable to store the commit message and updated the script to use this variable instead of directly referencing the output from needs.backport-target-branch.outputs.commit_message. This change improves readability and maintainability of the script.

Make the same modifications as in #2512.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@Yaminyam Yaminyam added this to the 24.09 milestone Dec 13, 2024
@Copilot Copilot bot review requested due to automatic review settings December 13, 2024 12:20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/backport.yml:149

  • The job name 'Create Bakport PR' contains a spelling mistake. It should be 'Create Backport PR'.
- name: Create Bakport PR
@Yaminyam Yaminyam modified the milestones: 24.09, 24.12 Dec 13, 2024
@github-actions github-actions bot added the size:S 10~30 LoC label Dec 13, 2024
@Yaminyam Yaminyam added the skip:changelog Make the action workflow to skip towncrier check label Dec 13, 2024
@achimnol achimnol added this pull request to the merge queue Dec 15, 2024
Merged via the queue into main with commit fc30408 Dec 15, 2024
36 of 37 checks passed
@achimnol achimnol deleted the ci/backport-single-quote-in-msg branch December 15, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S 10~30 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants